fix: keep adjusted risks visible to reviewers
This commit is contained in:
@@ -1180,10 +1180,18 @@ export default {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function filterSubmitterResolvedRiskCards(cards, businessStage) {
|
function filterSubmitterResolvedRiskCards(cards, businessStage) {
|
||||||
|
const viewerContext = riskViewerContext.value || {}
|
||||||
return filterSubmitterResolvedRiskCardsModel({
|
return filterSubmitterResolvedRiskCardsModel({
|
||||||
cards,
|
cards,
|
||||||
businessStage,
|
businessStage,
|
||||||
isCurrentApplicant: isCurrentApplicant.value,
|
isCurrentApplicant: isCurrentApplicant.value,
|
||||||
|
isPrivilegedRiskViewer: Boolean(
|
||||||
|
viewerContext.isAdminViewer
|
||||||
|
|| viewerContext.isBudgetReviewer
|
||||||
|
|| viewerContext.isDirectManagerReviewer
|
||||||
|
|| viewerContext.isFinanceReviewer
|
||||||
|
|| viewerContext.canViewApprovalRiskAdvice
|
||||||
|
),
|
||||||
expenseItems: expenseItems.value,
|
expenseItems: expenseItems.value,
|
||||||
standardAdjustmentMap: resolveCurrentStandardAdjustmentMap()
|
standardAdjustmentMap: resolveCurrentStandardAdjustmentMap()
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -61,10 +61,11 @@ export function filterSubmitterResolvedRiskCards({
|
|||||||
cards = [],
|
cards = [],
|
||||||
businessStage = 'reimbursement',
|
businessStage = 'reimbursement',
|
||||||
isCurrentApplicant = false,
|
isCurrentApplicant = false,
|
||||||
|
isPrivilegedRiskViewer = false,
|
||||||
expenseItems = [],
|
expenseItems = [],
|
||||||
standardAdjustmentMap = new Map()
|
standardAdjustmentMap = new Map()
|
||||||
} = {}) {
|
} = {}) {
|
||||||
if (businessStage !== 'reimbursement' || !isCurrentApplicant) {
|
if (businessStage !== 'reimbursement' || !isCurrentApplicant || isPrivilegedRiskViewer) {
|
||||||
return cards
|
return cards
|
||||||
}
|
}
|
||||||
return cards.filter((card) => !isRiskCardResolvedForSubmitter(card, expenseItems, standardAdjustmentMap))
|
return cards.filter((card) => !isRiskCardResolvedForSubmitter(card, expenseItems, standardAdjustmentMap))
|
||||||
|
|||||||
@@ -806,6 +806,17 @@ test('standard adjustment resolves submitter risk prompt only after accepted whi
|
|||||||
}),
|
}),
|
||||||
[originalRiskCard, reviewerNoticeCard]
|
[originalRiskCard, reviewerNoticeCard]
|
||||||
)
|
)
|
||||||
|
assert.deepEqual(
|
||||||
|
filterSubmitterResolvedRiskCards({
|
||||||
|
cards: [originalRiskCard, reviewerNoticeCard],
|
||||||
|
businessStage: 'reimbursement',
|
||||||
|
isCurrentApplicant: true,
|
||||||
|
isPrivilegedRiskViewer: true,
|
||||||
|
expenseItems,
|
||||||
|
standardAdjustmentMap
|
||||||
|
}),
|
||||||
|
[originalRiskCard, reviewerNoticeCard]
|
||||||
|
)
|
||||||
})
|
})
|
||||||
|
|
||||||
test('expense item upload remains limited to one receipt per detail row', () => {
|
test('expense item upload remains limited to one receipt per detail row', () => {
|
||||||
|
|||||||
Reference in New Issue
Block a user