refactor: enforce 800 line source limits
This commit is contained in:
@@ -7,7 +7,7 @@ const detailViewTemplate = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/TravelRequestDetailView.vue', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailViewScript = readFileSync(
|
||||
const detailViewComponentScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/TravelRequestDetailView.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
@@ -15,6 +15,40 @@ const detailExpenseModelScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/travelRequestDetailExpenseModel.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailViewSetupScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/travelRequestDetailSetup.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailSmartEntryScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/travelRequestDetailSmartEntryRecognition.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailAttachmentPreviewScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/useTravelRequestDetailAttachmentPreview.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailExpenseEditorScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/useTravelRequestDetailExpenseEditor.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailRiskSubmitScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/useTravelRequestDetailRiskSubmit.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailApprovalFlowScript = readFileSync(
|
||||
fileURLToPath(new URL('../src/views/scripts/useTravelRequestDetailApprovalFlow.js', import.meta.url)),
|
||||
'utf8'
|
||||
)
|
||||
const detailViewScript = [
|
||||
detailViewComponentScript,
|
||||
detailViewSetupScript,
|
||||
detailSmartEntryScript,
|
||||
detailAttachmentPreviewScript,
|
||||
detailExpenseEditorScript,
|
||||
detailRiskSubmitScript,
|
||||
detailApprovalFlowScript,
|
||||
detailExpenseModelScript
|
||||
].join('\n')
|
||||
const confirmDialogComponent = readFileSync(
|
||||
fileURLToPath(new URL('../src/components/shared/ConfirmDialog.vue', import.meta.url)),
|
||||
'utf8'
|
||||
@@ -126,7 +160,7 @@ test('detail submit warns on missing risk explanation and supports standard adju
|
||||
assert.match(runStandardAdjustmentRecalculation, /acceptExpenseClaimStandardAdjustment\(claimId, payload\)/)
|
||||
assert.doesNotMatch(runStandardAdjustmentRecalculation, /submitConfirmDialogOpen\.value = true/)
|
||||
assert.match(detailViewScript, /buildStandardAdjustmentPayloadModel\(\{[\s\S]*warnings:\s*submitRiskCards\.value/)
|
||||
const actionBusyStart = detailViewScript.indexOf('const actionBusy = computed')
|
||||
const actionBusyStart = detailViewScript.indexOf('actionBusy = computed')
|
||||
const actionBusyEnd = detailViewScript.indexOf('const profile = computed', actionBusyStart)
|
||||
assert.ok(actionBusyStart > -1 && actionBusyEnd > actionBusyStart)
|
||||
assert.doesNotMatch(detailViewScript.slice(actionBusyStart, actionBusyEnd), /standardAdjustmentBusy/)
|
||||
@@ -173,7 +207,7 @@ test('detail delete action allows admins or the applicant while the request is e
|
||||
|
||||
test('detail delete action does not allow in-progress applicant or claim manager fallback', () => {
|
||||
const canDeleteStart = detailViewScript.indexOf('const canDeleteRequest = computed')
|
||||
const canDeleteEnd = detailViewScript.indexOf('\n const isDirectManagerApprovalStage', canDeleteStart)
|
||||
const canDeleteEnd = detailViewScript.indexOf('\n const isDirectManagerApprovalStage', canDeleteStart)
|
||||
assert.ok(canDeleteStart >= 0)
|
||||
assert.ok(canDeleteEnd > canDeleteStart)
|
||||
const canDeleteBlock = detailViewScript.slice(canDeleteStart, canDeleteEnd)
|
||||
|
||||
Reference in New Issue
Block a user