YG-Soft/X-Financial
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(expenses): add authoritative pre-review workflow

Browse Source
This commit is contained in:
caoxiaozhu
2026-07-16 11:42:08 +08:00
parent ae3f02c35a
commit 6bdf65bc24
52 changed files with 4300 additions and 1069 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/services/api.js
View File

@@ -187,6 +187,12 @@ function sanitizeHeaders(headers) {
function buildApiResponseError(response, payload, { auth, handleUnauthorized }) {
const error = new Error(resolveErrorMessage(payload))
error.status = response.status
error.payload = payload
error.detail = payload?.detail
if (payload?.detail && typeof payload.detail === 'object') {
error.code = String(payload.detail.code || '').trim()
error.review = payload.detail.review || null
}
if (response.status === 401 && auth && handleUnauthorized && readAuthAccessToken()) {
error.code = 'AUTH_SESSION_EXPIRED'
notifyAuthSessionExpired()

20
web/src/services/reimbursements.js
View File

@@ -224,10 +224,26 @@ export function updateExpenseClaimItem(claimId, itemId, payload) {
})
}
export function submitExpenseClaim(claimId) {
function createPreReviewRequestId() {
if (typeof globalThis.crypto?.randomUUID === 'function') {
return `pre-review:${globalThis.crypto.randomUUID()}`
}
return `pre-review:${Date.now()}:${Math.random().toString(16).slice(2)}`
}
export function preReviewExpenseClaim(claimId, requestId = '') {
const normalizedRequestId = String(requestId || '').trim() || createPreReviewRequestId()
return apiRequest(`/reimbursements/claims/${encodeURIComponent(String(claimId || '').trim())}/pre-review`, {
method: 'POST',
headers: { 'X-Request-ID': normalizedRequestId },
body: JSON.stringify({})
})
}
export function submitExpenseClaim(claimId, payload = {}) {
return apiRequest(`/reimbursements/claims/${encodeURIComponent(String(claimId || '').trim())}/submit`, {
method: 'POST',
body: JSON.stringify({})
body: JSON.stringify(payload || {})
})
}

36
web/src/utils/expenseCaseTimeline.js
View File

@@ -35,6 +35,10 @@ const EVENT_PRESENTATION = {
application_returned: { label: '费用申请被退回', icon: 'mdi mdi-arrow-u-left-top', tone: 'warning' },
claim_returned: { label: '报销单被退回', icon: 'mdi mdi-arrow-u-left-top', tone: 'warning' },
reimbursement_draft_generated: { label: '报销草稿已自动生成', icon: 'mdi mdi-robot-outline', tone: 'success' },
receipt_received: { label: '票据已进入费用事件', icon: 'mdi mdi-receipt-text-plus-outline', tone: 'info' },
attachment_associated: { label: '票据已归集到报销草稿', icon: 'mdi mdi-file-link-outline', tone: 'success' },
application_pre_review_completed: { label: '费用申请 AI 预审已完成', icon: 'mdi mdi-shield-search-outline', tone: 'success' },
claim_pre_review_completed: { label: '报销单 AI 预审已完成', icon: 'mdi mdi-shield-search-outline', tone: 'success' },
payment_completed: { label: '付款已完成', icon: 'mdi mdi-cash-check', tone: 'success' },
application_archived: { label: '费用申请已归档', icon: 'mdi mdi-archive-check-outline', tone: 'success' }
}
@@ -125,6 +129,32 @@ function buildEventSummary(eventType, payload) {
}
}
if (eventType === 'receipt_received') {
const fileName = compactText(readField(payload, 'file_name', 'fileName'))
return fileName
? `${fileName} 已进入费用事件并完成票据识别。`
: '票据已进入费用事件并完成识别。'
}
if (eventType === 'attachment_associated') {
const claimNo = compactText(readField(payload, 'claim_no', 'claimNo'))
return claimNo
? `票据已自动归集到报销草稿 ${claimNo}。`
: '票据已自动归集到当前报销草稿。'
}
if (['application_pre_review_completed', 'claim_pre_review_completed'].includes(eventType)) {
const message = compactText(payload?.message)
if (message) {
return message
}
const passed = readField(payload, 'passed', 'passed')
const blockingCount = Number(readField(payload, 'blocking_risk_count', 'blockingRiskCount') || 0)
return passed === false
? `AI 预审发现 ${blockingCount} 条重大风险，请处理后重新预审。`
: 'AI 预审已通过，可以继续提交审批。'
}
if (eventType === 'application_archived') {
const reimbursementClaimNo = compactText(readField(payload, 'reimbursement_claim_no', 'reimbursementClaimNo'))
if (reimbursementClaimNo) {
@@ -175,13 +205,17 @@ function normalizeEvent(event, index) {
const occurredAt = readField(event, 'occurred_at', 'occurredAt')
const timestamp = new Date(occurredAt || '').getTime()
const payload = readField(event, 'payload_json', 'payloadJson') || {}
const isFailedPreReview = (
['application_pre_review_completed', 'claim_pre_review_completed'].includes(eventType)
&& readField(payload, 'passed', 'passed') === false
)
return {
id: compactText(event?.id) || `${eventType || 'event'}-${index}`,
eventType,
label: presentation.label,
icon: presentation.icon,
tone: presentation.tone,
tone: isFailedPreReview ? 'warning' : presentation.tone,
summary: buildEventSummary(eventType, payload),
actorLabel: eventType === 'historical_claim_imported' ? '系统' : resolveActorLabel(event),
occurredAt: compactText(occurredAt),

13
web/src/views/scripts/travelRequestDetailPreReview.js Normal file
View File

@@ -0,0 +1,13 @@
export function mapPreReviewFindingsToRiskFlags(preReview = {}) {
const findings = Array.isArray(preReview?.findings) ? preReview.findings : []
return findings.map((finding) => ({
...finding,
source: String(finding?.source || 'pre_review_finding').trim() || 'pre_review_finding',
label: finding?.message || '提交前预审风险',
business_stage: String(
finding?.business_stage || finding?.businessStage || 'reimbursement'
).trim() || 'reimbursement',
risk_domain: finding?.risk_domain || finding?.riskDomain || '',
visibility_scope: finding?.visibility_scope || finding?.visibilityScope || ''
}))
}

41
web/src/views/scripts/useTravelRequestDetailRiskSubmit.js
View File

@@ -3,6 +3,7 @@ import { computed, nextTick, ref, watch } from 'vue'
import {
acceptExpenseClaimStandardAdjustment,
calculateTravelReimbursement,
preReviewExpenseClaim,
submitExpenseClaim,
updateExpenseClaim
} from '../../services/reimbursements.js'
@@ -26,6 +27,7 @@ import {
normalizeRiskTone,
resolveRiskTags
} from './travelRequestDetailInsights.js'
import { mapPreReviewFindingsToRiskFlags } from './travelRequestDetailPreReview.js'
import {
buildCurrentStandardAdjustmentMap,
buildStandardAdjustmentPayload as buildStandardAdjustmentPayloadModel,
@@ -139,11 +141,16 @@ export function useTravelRequestDetailRiskSubmit({
}
function applyClaimRiskFlagsPayload(payload) {
const flags = Array.isArray(payload?.claim_risk_flags)
? payload.claim_risk_flags
: Array.isArray(payload?.claimRiskFlags)
? payload.claimRiskFlags
const flags = [
payload?.claim_risk_flags,
payload?.claimRiskFlags,
payload?.risk_flags_json,
payload?.riskFlags
].find(Array.isArray) || (
Array.isArray(payload?.pre_review?.findings)
? mapPreReviewFindingsToRiskFlags(payload.pre_review)
: null
)
if (!flags) {
return
}
@@ -657,7 +664,24 @@ export function useTravelRequestDetailRiskSubmit({
async function runSubmitRequest(claimId, documentNo, isApplication, taskSeq) {
try {
const payload = await submitExpenseClaim(claimId)
const reviewedClaim = await preReviewExpenseClaim(claimId)
if (taskSeq !== submitTaskSeq || String(request.value?.claimId || '').trim() !== claimId) {
return
}
applyClaimRiskFlagsPayload(reviewedClaim)
const preReview = reviewedClaim?.pre_review || reviewedClaim?.preReview || null
if (String(preReview?.decision || '').trim() === 'needs_fix') {
toast(preReview?.message || '自动检测发现需要先整改的风险，请处理后重新提交。')
emit('request-updated', { claimId })
return
}
const payload = await submitExpenseClaim(claimId, {
pre_review_id: String(preReview?.review_id || preReview?.reviewId || '').trim() || null,
input_fingerprint: String(
preReview?.input_fingerprint || preReview?.inputFingerprint || ''
).trim() || null
})
if (taskSeq !== submitTaskSeq || String(request.value?.claimId || '').trim() !== claimId) {
return
}
@@ -678,6 +702,12 @@ export function useTravelRequestDetailRiskSubmit({
emit('request-updated', { claimId })
} catch (error) {
if (taskSeq === submitTaskSeq) {
if (['PRE_REVIEW_NEEDS_FIX', 'PRE_REVIEW_CHANGED'].includes(error?.code)) {
applyClaimRiskFlagsPayload({ pre_review: error?.review })
toast(error?.review?.message || error?.message || '自动检测发现需要先整改的风险。')
emit('request-updated', { claimId })
return
}
toast(error?.message || '提交审批失败，请稍后重试。')
}
} finally {
@@ -693,7 +723,6 @@ export function useTravelRequestDetailRiskSubmit({
submitTaskSeq += 1
submitBusy.value = false
}
function disposeRiskSubmit() {
resetSubmitWorkState()
if (highlightedRiskCardTimer) {

39
web/tests/api-request.test.mjs
View File

@@ -243,6 +243,44 @@ async function testRejectsWithCustomTimeoutMessage() {
)
}
async function testPreservesStructuredPreReviewConflict() {
const review = {
review_id: 'review-conflict-001',
decision: 'needs_fix',
message: '住宿费超过标准，请先调整。',
findings: [{ risk_id: 'risk-001', severity: 'high' }]
}
global.fetch = async () => ({
ok: false,
status: 409,
async json() {
return {
detail: {
code: 'PRE_REVIEW_NEEDS_FIX',
message: '预审发现需整改风险。',
review
}
}
}
})
await assert.rejects(
() => apiRequest('/reimbursements/claims/claim-001/submit', {
method: 'POST',
body: '{}'
}),
(error) => {
assert.equal(error.status, 409)
assert.equal(error.code, 'PRE_REVIEW_NEEDS_FIX')
assert.equal(error.message, '预审发现需整改风险。')
assert.deepEqual(error.review, review)
assert.deepEqual(error.detail.review, review)
assert.deepEqual(error.payload.detail.review, review)
return true
}
)
}
async function run() {
await testUsesCustomContentTypeHeader()
await testSupportsBlobResponses()
@@ -251,6 +289,7 @@ async function run() {
await testRejectsCustomAuthorizationOverride()
await testUnauthorizedResponsePublishesSessionExpiredEvent()
await testFormatsValidationErrors()
await testPreservesStructuredPreReviewConflict()
await testRejectsWithCustomTimeoutMessage()
console.log('api-request tests passed')
}

42
web/tests/expense-case-timeline.test.mjs
View File

@@ -100,6 +100,48 @@ test('expense case timeline gives returned events an actionable reason', () => {
assert.equal(timeline.events[0].summary, '住宿票据缺少入住人信息')
})
test('expense case timeline explains receipt collection, association and AI pre-review', () => {
const timeline = buildExpenseCaseTimelineViewModel({
events: [
{
id: 'receipt-1',
event_type: 'receipt_received',
actor_id: 'employee@example.com',
occurred_at: '2026-07-13T01:00:00Z',
payload_json: { file_name: '上海出差高铁票.pdf' }
},
{
id: 'association-1',
event_type: 'attachment_associated',
actor_id: 'employee@example.com',
occurred_at: '2026-07-13T01:01:00Z',
payload_json: { claim_no: 'BX-20260713-001' }
},
{
id: 'pre-review-1',
event_type: 'claim_pre_review_completed',
actor_id: 'employee@example.com',
occurred_at: '2026-07-13T01:02:00Z',
payload_json: {
passed: false,
blocking_risk_count: 1,
message: '自动检测发现 1 条重大风险，请逐条填写原因后再提交审批。'
}
}
]
})
assert.deepEqual(timeline.events.map((event) => event.label), [
'票据已进入费用事件',
'票据已归集到报销草稿',
'报销单 AI 预审已完成'
])
assert.match(timeline.events[0].summary, /上海出差高铁票\.pdf/)
assert.match(timeline.events[1].summary, /BX-20260713-001/)
assert.equal(timeline.events[2].tone, 'warning')
assert.match(timeline.events[2].summary, /1 条重大风险/)
})
test('expense case timeline explains a historical import without pretending it is a business action', () => {
const timeline = buildExpenseCaseTimelineViewModel({
events: [

51
web/tests/reimbursement-pre-review-service.test.mjs Normal file
View File

@@ -0,0 +1,51 @@
import assert from 'node:assert/strict'
import test from 'node:test'
import {
preReviewExpenseClaim,
submitExpenseClaim
} from '../src/services/reimbursements.js'
test('reimbursement service sends pre-review request identity and submit handshake payload', async () => {
const requests = []
const originalFetch = globalThis.fetch
globalThis.fetch = async (url, options = {}) => {
requests.push({ url: String(url), options })
return {
ok: true,
status: 200,
async json() {
return { ok: true }
}
}
}
try {
await preReviewExpenseClaim('claim / 001', 'pre-review:test-request-001')
await submitExpenseClaim('claim / 001', {
pre_review_id: 'review-ready-001',
input_fingerprint: 'sha256:ready-input'
})
} finally {
globalThis.fetch = originalFetch
}
assert.equal(requests.length, 2)
assert.equal(
requests[0].url,
'/api/v1/reimbursements/claims/claim%20%2F%20001/pre-review'
)
assert.equal(requests[0].options.method, 'POST')
assert.equal(requests[0].options.headers['X-Request-ID'], 'pre-review:test-request-001')
assert.equal(requests[0].options.body, '{}')
assert.equal(
requests[1].url,
'/api/v1/reimbursements/claims/claim%20%2F%20001/submit'
)
assert.equal(requests[1].options.method, 'POST')
assert.deepEqual(JSON.parse(requests[1].options.body), {
pre_review_id: 'review-ready-001',
input_fingerprint: 'sha256:ready-input'
})
})

33
web/tests/travel-request-detail-pre-review.test.mjs Normal file
View File

@@ -0,0 +1,33 @@
import assert from 'node:assert/strict'
import test from 'node:test'
import { buildAttachmentRiskCards } from '../src/views/scripts/travelRequestDetailInsights.js'
import { mapPreReviewFindingsToRiskFlags } from '../src/views/scripts/travelRequestDetailPreReview.js'
test('structured pre-review findings remain visible as actionable risk cards', () => {
const flags = mapPreReviewFindingsToRiskFlags({
findings: [
{
risk_id: 'risk-visible-001',
source: 'platform_risk',
severity: 'high',
actionability: 'fixable_by_submitter',
business_stage: 'reimbursement',
message: '发票抬头不匹配，请重新上传。',
item_ids: ['item-001']
}
]
})
assert.equal(flags[0].source, 'platform_risk')
assert.notEqual(flags[0].source, 'ai_pre_review')
const cards = buildAttachmentRiskCards({
expenseItems: [{ id: 'item-001', itemNote: '' }],
claimRiskFlags: flags,
businessStage: 'reimbursement'
})
assert.equal(cards.length, 1)
assert.equal(cards[0].risk, '发票抬头不匹配，请重新上传。')
assert.equal(cards[0].actionability, 'fixable_by_submitter')
})

158
web/tests/travel-request-detail-submit-confirm.test.mjs
View File

@@ -59,9 +59,9 @@ const deleteDialogComponent = readFileSync(
)
function extractFunction(source, name) {
let signatureIndex = source.indexOf(`function ${name}(`)
let signatureIndex = source.indexOf(`async function ${name}(`)
if (signatureIndex === -1) {
signatureIndex = source.indexOf(`async function ${name}(`)
signatureIndex = source.indexOf(`function ${name}(`)
}
assert.notEqual(signatureIndex, -1, `${name} should exist`)
@@ -84,6 +84,46 @@ function extractFunction(source, name) {
assert.fail(`${name} body should be closed`)
}
function createSubmitRunner({
claimId = 'claim-001',
preReviewExpenseClaim,
submitExpenseClaim,
applyClaimRiskFlagsPayload = () => {},
toast = () => {},
emit = () => {}
}) {
const runSubmitRequest = extractFunction(detailViewScript, 'runSubmitRequest')
const factory = new Function(
'preReviewExpenseClaim',
'submitExpenseClaim',
'applyClaimRiskFlagsPayload',
'toast',
'emit',
'request',
'submitConfirmDialogOpen',
'submitBusy',
'submitTaskSeq',
`${runSubmitRequest}; return runSubmitRequest`
)
const submitConfirmDialogOpen = { value: true }
const submitBusy = { value: true }
return {
run: factory(
preReviewExpenseClaim,
submitExpenseClaim,
applyClaimRiskFlagsPayload,
toast,
emit,
{ value: { claimId } },
submitConfirmDialogOpen,
submitBusy,
1
),
submitConfirmDialogOpen,
submitBusy
}
}
test('detail submit opens a confirmation dialog before calling submit API', () => {
assert.match(detailViewTemplate, /<ConfirmDialog[\s\S]*:open="submitConfirmDialogOpen"[\s\S]*:confirm-text="submitConfirmText"[\s\S]*@close="closeSubmitConfirmDialog"[\s\S]*@confirm="confirmSubmitRequest"/)
assert.match(detailViewTemplate, /:secondary-text="submitConfirmSecondaryText"/)
@@ -94,7 +134,7 @@ test('detail submit opens a confirmation dialog before calling submit API', () =
assert.match(detailViewScript, /const submitConfirmDialogOpen = ref\(false\)/)
assert.match(detailViewTemplate, /v-if="submitBusy" class="expense-recognition-banner submit-progress-banner"/)
assert.doesNotMatch(detailViewScript, /preReviewExpenseClaim\(request\.value\.claimId\)/)
assert.match(detailViewScript, /preReviewExpenseClaim/)
assert.match(detailViewScript, /const submitActionLabel = computed/)
assert.match(detailViewScript, /const submitConfirmSecondaryText = computed/)
assert.match(detailViewScript, /submitConfirmDialogOpen\.value = true/)
@@ -111,10 +151,120 @@ test('detail submit opens a confirmation dialog before calling submit API', () =
assert.doesNotMatch(confirmSubmitRequest, /await /)
assert.doesNotMatch(confirmSubmitRequest, /submitExpenseClaim/)
const runSubmitRequest = extractFunction(detailViewScript, 'runSubmitRequest')
assert.match(runSubmitRequest, /submitExpenseClaim\(claimId\)/)
const preReviewIndex = runSubmitRequest.indexOf('preReviewExpenseClaim(claimId)')
const submitIndex = runSubmitRequest.indexOf('submitExpenseClaim(claimId,')
assert.ok(preReviewIndex > -1)
assert.ok(submitIndex > preReviewIndex)
assert.match(runSubmitRequest, /pre_review_id:[\s\S]*preReview\?\.review_id/)
assert.match(runSubmitRequest, /input_fingerprint:[\s\S]*preReview\?\.input_fingerprint/)
assert.match(runSubmitRequest, /taskSeq !== submitTaskSeq/)
})
test('detail submit uses the ready pre-review identity and fingerprint', async () => {
const calls = []
const appliedPayloads = []
const { run, submitBusy } = createSubmitRunner({
preReviewExpenseClaim: async (claimId) => {
calls.push(['pre-review', claimId])
return {
claim_risk_flags: [],
pre_review: {
decision: 'ready',
review_id: 'review-ready-001',
input_fingerprint: 'sha256:ready-input'
}
}
},
submitExpenseClaim: async (claimId, payload) => {
calls.push(['submit', claimId, payload])
return { status: 'submitted', approval_stage: 'manager' }
},
applyClaimRiskFlagsPayload: (payload) => appliedPayloads.push(payload)
})
await run('claim-001', 'BX-001', false, 1)
assert.deepEqual(calls, [
['pre-review', 'claim-001'],
[
'submit',
'claim-001',
{
pre_review_id: 'review-ready-001',
input_fingerprint: 'sha256:ready-input'
}
]
])
assert.equal(appliedPayloads.length, 1)
assert.equal(submitBusy.value, false)
})
test('detail submit stops after needs_fix and refreshes visible risks', async () => {
let submitCalls = 0
const appliedPayloads = []
const emitted = []
const toasts = []
const reviewedClaim = {
claim_risk_flags: [{ source: 'policy', severity: 'high' }],
pre_review: {
decision: 'needs_fix',
message: '住宿费超标，请先按标准调整。'
}
}
const { run, submitBusy } = createSubmitRunner({
preReviewExpenseClaim: async () => reviewedClaim,
submitExpenseClaim: async () => {
submitCalls += 1
return { status: 'submitted' }
},
applyClaimRiskFlagsPayload: (payload) => appliedPayloads.push(payload),
toast: (message) => toasts.push(message),
emit: (...args) => emitted.push(args)
})
await run('claim-001', 'BX-001', false, 1)
assert.equal(submitCalls, 0)
assert.deepEqual(appliedPayloads, [reviewedClaim])
assert.deepEqual(emitted, [['request-updated', { claimId: 'claim-001' }]])
assert.deepEqual(toasts, ['住宿费超标，请先按标准调整。'])
assert.equal(submitBusy.value, false)
})
test('structured pre-review 409 requests detail refresh so backend risks are refilled', async () => {
const emitted = []
const toasts = []
const structuredError = Object.assign(new Error('提交前预审已失效。'), {
code: 'PRE_REVIEW_NEEDS_FIX',
review: {
decision: 'needs_fix',
message: '发票抬头不匹配，请重新上传。',
findings: [{ risk_id: 'risk-001', severity: 'high' }]
}
})
const { run, submitBusy } = createSubmitRunner({
preReviewExpenseClaim: async () => ({
claim_risk_flags: [],
pre_review: {
decision: 'ready',
review_id: 'review-stale',
input_fingerprint: 'sha256:stale'
}
}),
submitExpenseClaim: async () => {
throw structuredError
},
toast: (message) => toasts.push(message),
emit: (...args) => emitted.push(args)
})
await run('claim-001', 'BX-001', false, 1)
assert.deepEqual(toasts, ['发票抬头不匹配，请重新上传。'])
assert.deepEqual(emitted, [['request-updated', { claimId: 'claim-001' }]])
assert.equal(submitBusy.value, false)
})
test('detail submit warns on missing risk explanation and supports standard adjustment', () => {
assert.match(detailViewTemplate, /:open="riskOverrideDialogOpen"/)
assert.match(detailViewTemplate, /:open="riskOverrideDialogOpen"[\s\S]*size="review"/)