fix: preserve reviewer risk notice after standard adjustment
This commit is contained in:
@@ -93,7 +93,7 @@ import {
|
||||
import {
|
||||
buildCurrentStandardAdjustmentMap,
|
||||
buildStandardAdjustmentPayload as buildStandardAdjustmentPayloadModel,
|
||||
filterSubmitterStandardAdjustedRiskCards as filterSubmitterStandardAdjustedRiskCardsModel,
|
||||
filterSubmitterResolvedRiskCards as filterSubmitterResolvedRiskCardsModel,
|
||||
isRiskCardMissingExpenseNote as isRiskCardMissingExpenseNoteModel,
|
||||
resolveExpenseItemForRiskCard as resolveExpenseItemForRiskCardModel
|
||||
} from './travelRequestDetailStandardAdjustment.js'
|
||||
@@ -1179,8 +1179,8 @@ export default {
|
||||
return resolveExpenseItemForRiskCardModel(card, expenseItems.value)
|
||||
}
|
||||
|
||||
function filterSubmitterStandardAdjustedRiskCards(cards, businessStage) {
|
||||
return filterSubmitterStandardAdjustedRiskCardsModel({
|
||||
function filterSubmitterResolvedRiskCards(cards, businessStage) {
|
||||
return filterSubmitterResolvedRiskCardsModel({
|
||||
cards,
|
||||
businessStage,
|
||||
isCurrentApplicant: isCurrentApplicant.value,
|
||||
@@ -1597,7 +1597,7 @@ export default {
|
||||
: []
|
||||
const scopedRiskCards = [
|
||||
...(hasActionableRiskCards ? [] : summaryRiskCards),
|
||||
...filterSubmitterStandardAdjustedRiskCards(directRiskCards, currentBusinessStage)
|
||||
...filterSubmitterResolvedRiskCards(directRiskCards, currentBusinessStage)
|
||||
]
|
||||
const riskCards = filterRiskCardsForVisibility(scopedRiskCards, riskViewerContext.value)
|
||||
|
||||
|
||||
@@ -31,14 +31,6 @@ export function resolveExpenseItemForRiskCard(card, expenseItems = []) {
|
||||
|| null
|
||||
}
|
||||
|
||||
export function hasStandardAdjustmentForItem(item, standardAdjustmentMap = new Map()) {
|
||||
const itemId = normalizeText(item?.id)
|
||||
if (!itemId) {
|
||||
return false
|
||||
}
|
||||
return Boolean(item?.standardAdjustmentAccepted || standardAdjustmentMap.has(itemId))
|
||||
}
|
||||
|
||||
export function isRiskCardMissingExpenseNote(card, expenseItems = []) {
|
||||
const item = resolveExpenseItemForRiskCard(card, expenseItems)
|
||||
if (!item) {
|
||||
@@ -47,7 +39,15 @@ export function isRiskCardMissingExpenseNote(card, expenseItems = []) {
|
||||
return !normalizeText(item.itemNote)
|
||||
}
|
||||
|
||||
function isRiskCardCoveredByStandardAdjustment(card, expenseItems, standardAdjustmentMap) {
|
||||
export function hasStandardAdjustmentForItem(item, standardAdjustmentMap = new Map()) {
|
||||
const itemId = normalizeText(item?.id)
|
||||
if (!itemId) {
|
||||
return false
|
||||
}
|
||||
return Boolean(item?.standardAdjustmentAccepted || standardAdjustmentMap.has(itemId))
|
||||
}
|
||||
|
||||
function isRiskCardResolvedForSubmitter(card, expenseItems, standardAdjustmentMap) {
|
||||
if (normalizeText(card?.source) === STANDARD_ADJUSTMENT_RISK_SOURCE) {
|
||||
return true
|
||||
}
|
||||
@@ -57,7 +57,7 @@ function isRiskCardCoveredByStandardAdjustment(card, expenseItems, standardAdjus
|
||||
)
|
||||
}
|
||||
|
||||
export function filterSubmitterStandardAdjustedRiskCards({
|
||||
export function filterSubmitterResolvedRiskCards({
|
||||
cards = [],
|
||||
businessStage = 'reimbursement',
|
||||
isCurrentApplicant = false,
|
||||
@@ -67,7 +67,7 @@ export function filterSubmitterStandardAdjustedRiskCards({
|
||||
if (businessStage !== 'reimbursement' || !isCurrentApplicant) {
|
||||
return cards
|
||||
}
|
||||
return cards.filter((card) => !isRiskCardCoveredByStandardAdjustment(card, expenseItems, standardAdjustmentMap))
|
||||
return cards.filter((card) => !isRiskCardResolvedForSubmitter(card, expenseItems, standardAdjustmentMap))
|
||||
}
|
||||
|
||||
function extractRiskCardMoneyValues(card) {
|
||||
|
||||
Reference in New Issue
Block a user